C0urante commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1119219553
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##########
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set<String> tags) {
sourceRecordWriteTotal = createTemplate("source-record-write-total",
SOURCE_TASK_GROUP_NAME,
"The number of records output
from the transformations and written to Kafka for this" +
" task belonging to the named
source connector in this worker, since the task was " +
- "last restarted.",
+ "last restarted. This is after
transformations are applied and excludes any records " +
+ "filtered out by the
transformations.",
Review Comment:
Ah yeah, uniformity is probably worth striving for here. IMO adding this
sentence makes some of language earlier in the description redundant; WDYT
about changing the descriptions of both to start with "The [average per-second]
number of records written to Kafka for this"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
