Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1129266598
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -1379,7 +1411,8 @@ public void handle(OffsetCommitResponse commitResponse,
RequestFuture<Void> futu
future.raise(error);
return;
} else if (error == Errors.COORDINATOR_LOAD_IN_PROGRESS
- || error == Errors.UNKNOWN_TOPIC_OR_PARTITION)
{
+ || error == Errors.UNKNOWN_TOPIC_OR_PARTITION
+ || error == Errors.UNKNOWN_TOPIC_ID) {
Review Comment:
With the synchronous API in the consumer, the error is not surfaced (only
`true`/`false`). I added the missing tests to exercise the asynchronous API for
this use case, and it did expose the `UnknownTopicIdException` to the user.
Since it violates the API contract which exclusively relies on topic names, I
raised the error `UNKNOWN_TOPIC_OR_PARTITION` when an `UNKNOWN_TOPIC_ID` is
returned in the offset commit response. Do you think this is sensible?
I added the corresponding unit tests for the consumer coordinator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
