Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1134485210
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -2917,34 +2925,33 @@ class GroupCoordinatorTest {
@Test
def testFetchAllOffsets(): Unit = {
- val tp1 = new TopicPartition("topic", 0)
- val tp2 = new TopicPartition("topic", 1)
- val tp3 = new TopicPartition("other-topic", 0)
val offset1 = offsetAndMetadata(15)
val offset2 = offsetAndMetadata(16)
val offset3 = offsetAndMetadata(17)
+ val (topicId, otherTopicId) = (Uuid.randomUuid(), Uuid.randomUuid())
+ val tip1 = new TopicIdPartition(topicId, 0, "topic")
+ val tip2 = new TopicIdPartition(topicId, 1, "topic")
+ val tip3 = new TopicIdPartition(otherTopicId, 0, "other-topic")
Review Comment:
Thanks, applied the same pattern in few other places too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
