Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133971136
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala:
##########
@@ -386,175 +386,269 @@ class GroupMetadataTest {
@Test
def testOffsetCommit(): Unit = {
- val partition = new TopicPartition("foo", 0)
+ val partition = new TopicIdPartition(Uuid.randomUuid, new
TopicPartition("foo", 0))
val offset = offsetAndMetadata(37)
val commitRecordOffset = 3
group.prepareOffsetCommit(Map(partition -> offset))
- assertTrue(group.hasOffsets)
- assertEquals(None, group.offset(partition))
+ assertOffsets(
Review Comment:
Sure, that makes sense. This was just an attempt to improve readability by
avoiding the sequences of added `assertEquals`, but I understand the concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
