mimaison commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1140384184
########## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java: ########## @@ -162,6 +174,15 @@ Duration syncTopicConfigsInterval() { } } + String useIncrementalAlterConfigs() { + String prop = getString(USE_INCREMENTAL_ALTER_CONFIG); + if (prop.equals(NEVER_USE_INCREMENTAL_ALTER_CONFIG) || prop.equals(REQUIRE_INCREMENTAL_ALTER_CONFIG)) { Review Comment: We can set the valid values when defining the config. For example see https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java#L354-L355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org