vcrfxia commented on code in PR #13497:
URL: https://github.com/apache/kafka/pull/13497#discussion_r1163410451


##########
streams/src/test/java/org/apache/kafka/streams/integration/StreamStreamJoinIntegrationTest.java:
##########
@@ -384,7 +528,7 @@ public void testOuterRepartitioned() {
     public void testMultiInner() {
         STREAMS_CONFIG.put(StreamsConfig.APPLICATION_ID_CONFIG, appID + 
"-multi-inner");
 
-        final List<List<TestRecord<Long, String>>> expectedResult = 
Arrays.asList(
+        @SuppressWarnings("RedundantTypeArguments (explicit type arguments 
speedup compilation and analysis time)") final List<List<TestRecord<Long, 
String>>> expectedResult = Arrays.asList(

Review Comment:
   Hmm.. I'm not sure where that suppression came from. Probably an accident, I 
will remove it.
   
   The reason the explicit types are added below is because I was getting an 
error that type inference slows down if there are too many variadic arguments 
passed to a method with a generic that requires type inference. I forget if it 
was just my IDE complaining or if spotbugs was failing too but I figure adding 
the types in doesn't introduce any harm.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to