[GitHub] [kafka] vcrfxia commented on a diff in pull request #13497: KAFKA-14834: [2/N] Test coverage for out-of-order data in joins

[via GitHub]

vcrfxia commented on code in PR #13497:
URL: https://github.com/apache/kafka/pull/13497#discussion_r1163410809


##########
streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java:
##########
@@ -88,31 +88,35 @@ public static Collection<Object[]> data() {
     StreamsBuilder builder;
 
     private final List<Input<String>> input = Arrays.asList(
-        new Input<>(INPUT_TOPIC_LEFT, null),
-        new Input<>(INPUT_TOPIC_RIGHT, null),
-        new Input<>(INPUT_TOPIC_LEFT, "A"),
-        new Input<>(INPUT_TOPIC_RIGHT, "a"),
-        new Input<>(INPUT_TOPIC_LEFT, "B"),
-        new Input<>(INPUT_TOPIC_RIGHT, "b"),
-        new Input<>(INPUT_TOPIC_LEFT, null),
-        new Input<>(INPUT_TOPIC_RIGHT, null),
-        new Input<>(INPUT_TOPIC_LEFT, "C"),
-        new Input<>(INPUT_TOPIC_RIGHT, "c"),
-        new Input<>(INPUT_TOPIC_RIGHT, null),
-        new Input<>(INPUT_TOPIC_LEFT, null),
-        new Input<>(INPUT_TOPIC_RIGHT, null),
-        new Input<>(INPUT_TOPIC_RIGHT, "d"),
-        new Input<>(INPUT_TOPIC_LEFT, "D")
+        new Input<>(INPUT_TOPIC_LEFT, null, 1),
+        new Input<>(INPUT_TOPIC_RIGHT, null, 2),
+        new Input<>(INPUT_TOPIC_LEFT, "A", 3),
+        new Input<>(INPUT_TOPIC_RIGHT, "a", 4),
+        new Input<>(INPUT_TOPIC_LEFT, "B", 5),
+        new Input<>(INPUT_TOPIC_RIGHT, "b", 6),
+        new Input<>(INPUT_TOPIC_LEFT, null, 7),
+        new Input<>(INPUT_TOPIC_RIGHT, null, 8),
+        new Input<>(INPUT_TOPIC_LEFT, "C", 9),
+        new Input<>(INPUT_TOPIC_RIGHT, "c", 10),
+        new Input<>(INPUT_TOPIC_RIGHT, null, 11),
+        new Input<>(INPUT_TOPIC_LEFT, null, 12),
+        new Input<>(INPUT_TOPIC_RIGHT, null, 13),
+        new Input<>(INPUT_TOPIC_RIGHT, "d", 14),
+        new Input<>(INPUT_TOPIC_LEFT, "D", 15),
+        new Input<>(INPUT_TOPIC_LEFT, "E", 4), // out-of-order data

Review Comment:
   Yeah, I noticed this as well. If you don't think having the out-of-order 
data in stream-stream join tests is valuable, I can open a follow-up PR to 
remove this (to reduce noise). Just LMK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org