cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173062692


##########
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##########
@@ -324,4 +329,29 @@ class ZkMigrationIntegrationTest {
       assertTrue(firstProducerIdBlock.firstProducerId() < 
producerIdBlock.firstProducerId())
     }
   }
+
+  /**
+   * Start a KRaft cluster with migrations enabled, verify that the controller 
does not accept metadata changes
+   * through the RPCs
+   */

Review Comment:
   We should also explain in this comment why the migration does not proceed 
beyond premigration (I assume it's because we're waiting for brokers and we 
don't have any due to brokers =  0)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to