jeffkbkim commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1192476699
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##########
@@ -357,6 +366,94 @@ public static Record newCurrentAssignmentTombstoneRecord(
);
}
+ /**
+ * Creates a GroupMetadata record.
+ *
+ * @param group The generic group.
+ * @param memberAssignments The assignment by member id.
+ * @param metadataVersion The metadata version.
+ * @return The record.
+ */
+ public static Record newGroupMetadataRecord(
+ GenericGroup group,
+ Map<String, byte[]> memberAssignments,
Review Comment:
i think you're saying that ideally we want to create a record solely from
the group i.e. update the group with the assignment and pass it into this
method. However, we can't because we don't use timeline data structures that
could revert if append fails. is my understanding correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
