dajac commented on code in PR #13704: URL: https://github.com/apache/kafka/pull/13704#discussion_r1192506160
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ########## @@ -357,6 +366,94 @@ public static Record newCurrentAssignmentTombstoneRecord( ); } + /** + * Creates a GroupMetadata record. + * + * @param group The generic group. + * @param memberAssignments The assignment by member id. + * @param metadataVersion The metadata version. + * @return The record. + */ + public static Record newGroupMetadataRecord( + GenericGroup group, + Map<String, byte[]> memberAssignments, Review Comment: it is actually the other way around, the generic group is mutable so we could mutate it whenever we want here, i think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org