Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1203965540
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##########
@@ -129,16 +150,19 @@
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertSame;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;
public abstract class ConsumerCoordinatorTest {
- private final String topic1 = "test1";
- private final String topic2 = "test2";
- private final TopicPartition t1p = new TopicPartition(topic1, 0);
- private final TopicPartition t2p = new TopicPartition(topic2, 0);
- private final String groupId = "test-group";
+ private static String topic1 = "test1";
+ private static String topic2 = "test2";
+ private static TopicPartition t1p = new TopicPartition(topic1, 0);
+ private static TopicIdPartition ti1p = new
TopicIdPartition(Uuid.randomUuid(), t1p);
Review Comment:
I think David probably hints at consolidating both in one defining object to
ease future updates of topic-partition to topic ids. I updated the test class
as per David's comment, I am happy to revert if this brings too many LoC
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
