Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204087015
##########
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##########
@@ -489,24 +489,23 @@ class AuthorizerIntegrationTest extends BaseRequestTest {
}
private def createOffsetCommitRequest = {
- new requests.OffsetCommitRequest.Builder(
- new OffsetCommitRequestData()
- .setGroupId(group)
- .setMemberId(JoinGroupRequest.UNKNOWN_MEMBER_ID)
- .setGenerationId(1)
- .setTopics(Collections.singletonList(
- new OffsetCommitRequestData.OffsetCommitRequestTopic()
- .setName(topic)
- .setPartitions(Collections.singletonList(
- new OffsetCommitRequestData.OffsetCommitRequestPartition()
- .setPartitionIndex(part)
- .setCommittedOffset(0)
-
.setCommittedLeaderEpoch(RecordBatch.NO_PARTITION_LEADER_EPOCH)
- .setCommitTimestamp(OffsetCommitRequest.DEFAULT_TIMESTAMP)
- .setCommittedMetadata("metadata")
- )))
- )
- ).build()
+ val data = new OffsetCommitRequestData()
+ .setGroupId(group)
+ .setMemberId(JoinGroupRequest.UNKNOWN_MEMBER_ID)
+ .setGenerationId(1)
+ .setTopics(Collections.singletonList(
+ new OffsetCommitRequestData.OffsetCommitRequestTopic()
+ .setName(topic)
+ .setPartitions(Collections.singletonList(
+ new OffsetCommitRequestData.OffsetCommitRequestPartition()
+ .setPartitionIndex(part)
+ .setCommittedOffset(0)
+ .setCommittedLeaderEpoch(RecordBatch.NO_PARTITION_LEADER_EPOCH)
+ .setCommitTimestamp(OffsetCommitRequest.DEFAULT_TIMESTAMP)
+ .setCommittedMetadata("metadata")
+ )))
+ )
+ new requests.OffsetCommitRequest.Builder(data, true).build()
Review Comment:
That is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
