clolov commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1568651608
Okay, in principle I agree that cleaning should be restarted, but I do not
understand why you want to mark the topicPartition as failed
```
override def markPartitionFailed(topicPartition: TopicPartition): Unit = {
super.markPartitionFailed(topicPartition) <- I DO NOT UNDERSTAND THE
PURPOSE OF THIS
info(s"For ReplicaAlterLogDirsThread, may also need to resume log cleaner
for partition $topicPartition")
replicaMgr.logManager.resumeCleaning(topicPartition)
}
```
My overarching question is that if we mark a partition as failed regardless
of whether it or its ReplicaAlterLogDirsThread fails does this not mean that
leadership will change and no traffic will be served by the replica on this
broker anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
