jolshan commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1212290566


##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1019,13 +1029,14 @@ class ReplicaManager(val config: KafkaConfig,
   }
 
   /**
-   * Append the messages to the local replica logs
+   * Append the messages to the local replica logs. 
ReplicaManager#appendRecords should usually be
+   * used instead of this method.

Review Comment:
   Is there a strong reason why appendRecords is preferred, but in this case we 
don't use it? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to