jolshan commented on code in PR #13811:
URL: https://github.com/apache/kafka/pull/13811#discussion_r1220504060
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -1599,6 +1599,8 @@ public void handleResponse(AbstractResponse response) {
fatalError(Errors.PRODUCER_FENCED.exception());
} else if (error == Errors.TRANSACTIONAL_ID_AUTHORIZATION_FAILED) {
fatalError(error.exception());
+ } else if (error == Errors.INVALID_TXN_STATE) {
Review Comment:
I went down a very long rabbit hole to find that we only returned
INVALID_TXN_STATE for a short time from this request.
https://github.com/apache/kafka/commit/1f2451d4e7e3766540d3650d177e304fcddf49b8
(here's the commit that removed this error).
We never removed it from the errors returned I suppose because some really
old broker could return it.
Having this here doesn't hurt, I was just curious about the history behind
it. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
