lucasbru commented on code in PR #13811:
URL: https://github.com/apache/kafka/pull/13811#discussion_r1221565214
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -1376,7 +1376,7 @@ public void handleResponse(AbstractResponse response) {
fatalError(error.exception());
return;
} else if (error == Errors.INVALID_TXN_STATE) {
- fatalError(new KafkaException(error.exception()));
Review Comment:
I think, for one, it is rather unlikely that a client matches exactly the
wrapped exception.
The accepted KIP states: "For customized EOS use case, user needs to change
their exception catching logic ..... However, all the thrown exceptions' base
type would still be KafkaException, so the effect should be minimal."
So I would say these kinds of backward incompatible changes around
exceptions were expected when the KIP was accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
