dajac commented on code in PR #13823:
URL: https://github.com/apache/kafka/pull/13823#discussion_r1223913820
##########
server-common/src/test/java/org/apache/kafka/server/util/MockTime.java:
##########
@@ -27,15 +23,21 @@
* 1. This has an associated scheduler instance for managing background tasks
in a deterministic way.
* 2. This doesn't support the `auto-tick` functionality as it interacts badly
with the current implementation of `MockScheduler`.
*/
-class MockTime(currentTimeMs: Long, currentHiResTimeNs: Long) extends
JMockTime(0, currentTimeMs, currentHiResTimeNs) {
-
- def this() = this(System.currentTimeMillis(), System.nanoTime())
+public class MockTime extends org.apache.kafka.common.utils.MockTime {
Review Comment:
Hum... Implementing AutoCloseable alone does not help. We would need to
change all the usages to call `close` to make it work, right?
My goal with this patch is to move it from core to server-common without
changing it. I think that we could consider doing this later, if it brings
anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
