divijvaidya commented on code in PR #13823:
URL: https://github.com/apache/kafka/pull/13823#discussion_r1224073997
##########
server-common/src/test/java/org/apache/kafka/server/util/MockTime.java:
##########
@@ -27,15 +23,21 @@
* 1. This has an associated scheduler instance for managing background tasks
in a deterministic way.
* 2. This doesn't support the `auto-tick` functionality as it interacts badly
with the current implementation of `MockScheduler`.
*/
-class MockTime(currentTimeMs: Long, currentHiResTimeNs: Long) extends
JMockTime(0, currentTimeMs, currentHiResTimeNs) {
-
- def this() = this(System.currentTimeMillis(), System.nanoTime())
+public class MockTime extends org.apache.kafka.common.utils.MockTime {
Review Comment:
Many automatic bug finders will flag a class if it is marked as
AutoCloseable but is not closed properly in the code. That is one advantage of
using this interface that I find very useful. But yes, we can do it separately
outside this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
