showuon commented on code in PR #13828:
URL: https://github.com/apache/kafka/pull/13828#discussion_r1224130115
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -189,6 +192,36 @@ void testRemoteLogMetadataManagerWithUserDefinedConfigs() {
assertFalse(metadataMangerConfig.containsKey("remote.log.metadata.y"));
}
+ @Test
Review Comment:
Good idea. Added!
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -505,7 +507,14 @@ class KafkaServer(
KafkaServer.MIN_INCREMENTAL_FETCH_SESSION_EVICTION_MS))
// Start RemoteLogManager before broker start serving the requests.
- remoteLogManager.foreach(_.startup())
+ remoteLogManagerOpt.foreach(rlm => {
+ val listenerName =
ListenerName.normalised(config.remoteLogManagerConfig.remoteLogMetadataManagerListenerName())
+ val endpoint = brokerInfo.broker.endPoints.find(e =>
e.listenerName.equals(listenerName))
+ .getOrElse(throw new
ConfigException(RemoteLogManagerConfig.REMOTE_LOG_METADATA_MANAGER_LISTENER_NAME_PROP
+
+ " should be set as a listener name within valid broker listener
name list."))
+ rlm.endPoint(Optional.of(endpoint))
Review Comment:
Good point. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
