[GitHub] [kafka] divijvaidya commented on a diff in pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

[via GitHub]

divijvaidya commented on code in PR #13828:
URL: https://github.com/apache/kafka/pull/13828#discussion_r1224171314


##########
clients/src/main/java/org/apache/kafka/common/network/ListenerName.java:
##########
@@ -36,6 +36,7 @@ public static ListenerName 
forSecurityProtocol(SecurityProtocol securityProtocol
      * Create an instance with the provided value converted to uppercase.
      */
     public static ListenerName normalised(String value) {
+        Objects.requireNonNull(value);

Review Comment:
   nit
   do we want to check for empty and whitespaces, using `Utils.isBlank()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org