divijvaidya commented on code in PR #13950:
URL: https://github.com/apache/kafka/pull/13950#discussion_r1250760152
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -172,13 +172,11 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHarness with Logging wi
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testCreateWhenAlreadyExists(quorum: String): Unit = {
- val numPartitions = 1
-
// create the topic
+ TestUtils.createTopicWithAdmin(adminClient, testTopicName, brokers, 1, 1)
+
val createOpts = new TopicCommandOptions(
Array("--partitions", numPartitions.toString, "--replication-factor",
"1", "--topic", testTopicName))
- createAndWaitTopic(createOpts)
Review Comment:
Oh, I specified incorrect details in JIRA! We don't want to replace
`createAndWaitTopic` because that is the function which is under test in this
file. We want to replace occurrences of `adminClient.createTopics` with the
utility function. Apologies for the confusion. Can you please revert back the
changes to createAndWaitTopic (but keep the ones where we are using
adminClient.createTopics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
