divijvaidya commented on code in PR #13950:
URL: https://github.com/apache/kafka/pull/13950#discussion_r1251003798
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -845,24 +812,19 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHarness with Logging wi
Set(new TopicPartition(testTopicName, 0)).asJava
)
- adminClient.createTopics(
- Collections.singletonList(new NewTopic(testTopicName, 1, 1.toShort))
- ).all().get()
- waitForTopicCreated(testTopicName)
+ TestUtils.createTopicWithAdmin(adminClient, testTopicName, brokers, 1, 1)
val output = TestUtils.grabConsoleOutput(
topicService.describeTopic(new TopicCommandOptions(Array("--topic",
testTopicName))))
- val rows = output.split("\n")
+ val rows = output.split(System.lineSeparator())
assertEquals(2, rows.size)
Review Comment:
please print output here as well. It helps in debugging when this assertion
fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
