jolshan commented on code in PR #13956:
URL: https://github.com/apache/kafka/pull/13956#discussion_r1260015211
##########
core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala:
##########
@@ -346,6 +346,7 @@ abstract class AbstractConsumerTest extends BaseRequestTest
{
partitionsToAssign:
Set[TopicPartition],
userRebalanceListener:
ConsumerRebalanceListener)
extends ShutdownableThread("daemon-consumer-assignment", false) {
+ setDaemon(true)
Review Comment:
It seems like one property of shutdownable thread is that we make it
non-daemon and we need to explicitly shut it down. Were the try blocks not
enough to fix the issue? Alternatively, can we make this a thread class that
isn't shutdownable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
