nicktelford commented on code in PR #13993:
URL: https://github.com/apache/kafka/pull/13993#discussion_r1261077502
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -119,6 +119,7 @@ public final class ConsumerCoordinator extends
AbstractCoordinator {
private Set<String> joinedSubscription;
private MetadataSnapshot metadataSnapshot;
private MetadataSnapshot assignmentSnapshot;
+ private boolean metadataUpdated;
Review Comment:
On reflection, I'm not convinced that this strategy will work, because
there's already a shortcut on the `version` check, which means that the
performance I'm seeing is when `assignmentSnapshot.version !=
metadataSnapshot.version`, so we definitely need to do the deep-equality check
to determine if the new version of the metadata is actually different from the
previous version.
I'm looking into some alternatives around whether we can represent this
internal metadata differently, in a way that's more efficient to compare.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
