nicktelford commented on code in PR #13993:
URL: https://github.com/apache/kafka/pull/13993#discussion_r1261318387
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -119,6 +119,7 @@ public final class ConsumerCoordinator extends
AbstractCoordinator {
private Set<String> joinedSubscription;
private MetadataSnapshot metadataSnapshot;
private MetadataSnapshot assignmentSnapshot;
+ private boolean metadataUpdated;
Review Comment:
I've revised the implementation to instead attempt to optimize the
comparison itself in 63ee9ab, but I'm not entirely sure that it will perform
better.
I'd like to construct a micro-benchmark for it, but I honestly have no idea
how I'd run a micro-benchmark on this part of the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
