philipnee commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1636359925
@flashmouse thansk for the PR - I was the one who wrote the if-else if -else
block. I'm a bit surprised that I actually made this mistake, so I held it off
for a few days just to make sure. As you have already provided a case that
breaks that existing logic, could you implement this as part of the test? Also,
could you provide a test case that fails `if (consumerPartitionCount <
otherConsumerPartitionCount) {` but succeeds in `if (consumerPartitionCount + 1
< otherConsumerPartitionCount) {`
This would help massively for the reviews and documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
