dajac commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1264964347
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -579,4 +618,32 @@ public void shutdown() {
Utils.closeQuietly(runtime, "coordinator runtime");
log.info("Shutdown complete.");
}
+
+ private static boolean isGroupIdNotEmpty(String groupId) {
+ return groupId != null && !groupId.isEmpty();
+ }
+
+ private static Errors toResponseError(Errors appendError) {
+ switch (appendError) {
+ case UNKNOWN_TOPIC_OR_PARTITION:
+ case NOT_ENOUGH_REPLICAS:
+ case NOT_ENOUGH_REPLICAS_AFTER_APPEND:
+ return COORDINATOR_NOT_AVAILABLE;
+
+ case NOT_LEADER_OR_FOLLOWER:
+ case KAFKA_STORAGE_ERROR:
+ return NOT_COORDINATOR;
+
+ case REQUEST_TIMED_OUT:
Review Comment:
This request timeout was coming from the delayed produce op in the
purgatory. We don't have this anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
