muralibasani commented on PR #13417: URL: https://github.com/apache/kafka/pull/13417#issuecomment-1645092579
> @muralibasani thanks, this is just a first pass. > > Looks like there are still some checkstyle errors to fix and a couple of errors on KafkaClusterTestKit. Can you also avoid moving imports around and other formatting changes as it makes the review harder. Should we use a Map instead of introducing Pair? @fvaleri fixed checkstyle errors, imports and KafkaClusterTestKit. Regarding Pair, I can change to Map, but in scala it more reflects a Pair. Need to fix my IDE for checkstyle, formatting keeps changing if I open the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
