muralibasani commented on PR #13417:
URL: https://github.com/apache/kafka/pull/13417#issuecomment-1647813211

   > Hi @muralibasani, thanks for the additional work. I left some comments.
   > 
   > As @mimaison, I also think that it would be better to create a dedicated 
PR for metadata and storage classes, to be merged before this one. I also think 
that methods migrated to LogConfig should replace the ones in KafkaConfig, so 
that we can test them properly.
   
   @fvaleri @mimaison to be sure,  I create another PR keeping KafkaConfig 
usage in StorageTool. And this PR for LogConfig changes. Right ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to