mimaison commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1269270009
########## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java: ########## @@ -85,6 +89,26 @@ public String version() { return AppInfoParser.getVersion(); } + @Override + public boolean alterOffsets(Map<String, String> config, Map<Map<String, ?>, Map<String, ?>> offsets) { Review Comment: Yeah I've not looked at the background but I agree with Yash, it looks strange -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org