ex172000 commented on code in PR #14093:
URL: https://github.com/apache/kafka/pull/14093#discussion_r1274426209
##########
connect/runtime/src/main/java/org/apache/kafka/connect/converters/BooleanConverterConfig.java:
##########
@@ -25,13 +25,13 @@
*/
public class BooleanConverterConfig extends ConverterConfig {
Review Comment:
Checked the code and seems only NumberConverter has a config applied to
IntegerConverter, LongConverter and FloatConverter. Classes like
ByteArrayConverter does not have a config. Also seems this config does not have
any special props, is there a reason to add it?
##########
connect/runtime/src/test/java/org/apache/kafka/connect/converters/BooleanConverterTest.java:
##########
@@ -74,10 +74,12 @@ public void testFromConnectNull() {
@Test
public void testToConnect() {
assertEquals(Schema.OPTIONAL_BOOLEAN_SCHEMA,
converter.toConnectData(TOPIC, TRUE).schema());
- assertEquals(Schema.OPTIONAL_BOOLEAN_SCHEMA,
converter.toConnectData(TOPIC, FALSE).schema());
- assertEquals(Schema.OPTIONAL_BOOLEAN_SCHEMA,
converter.toConnectData(TOPIC, null).schema());
assertTrue((Boolean) converter.toConnectData(TOPIC, TRUE).value());
+
+ assertEquals(Schema.OPTIONAL_BOOLEAN_SCHEMA,
converter.toConnectData(TOPIC, FALSE).schema());
Review Comment:
The original test validates the value, is there a reason to remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
