hgeraldino commented on code in PR #14093:
URL: https://github.com/apache/kafka/pull/14093#discussion_r1275002080
##########
connect/runtime/src/test/java/org/apache/kafka/connect/converters/BooleanConverterTest.java:
##########
@@ -74,10 +74,12 @@ public void testFromConnectNull() {
@Test
public void testToConnect() {
assertEquals(Schema.OPTIONAL_BOOLEAN_SCHEMA,
converter.toConnectData(TOPIC, TRUE).schema());
- assertEquals(Schema.OPTIONAL_BOOLEAN_SCHEMA,
converter.toConnectData(TOPIC, FALSE).schema());
- assertEquals(Schema.OPTIONAL_BOOLEAN_SCHEMA,
converter.toConnectData(TOPIC, null).schema());
assertTrue((Boolean) converter.toConnectData(TOPIC, TRUE).value());
+
+ assertEquals(Schema.OPTIONAL_BOOLEAN_SCHEMA,
converter.toConnectData(TOPIC, FALSE).schema());
Review Comment:
I'm sorry I don't quite follow your question. Which test are you referring
to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
