divijvaidya commented on code in PR #14104:
URL: https://github.com/apache/kafka/pull/14104#discussion_r1276043856


##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -558,6 +618,38 @@ void 
testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws Excepti
         verify(mockLog, never()).updateHighestOffsetInRemoteStorage(anyLong());
     }
 
+    @Test
+    void testCopyLogSegmentsToRemoteShouldNotCopySegmentWithCorruptedIndexes() 
throws Exception {

Review Comment:
   can we add test for other types of corruption as well? e.g. in the disk full 
issue that you mentioned in the description, the "corruption" is not index 
missing, instead it is an existing index file not having all entries as 
expected. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to