Nickstery commented on code in PR #14104:
URL: https://github.com/apache/kafka/pull/14104#discussion_r1293155986
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -574,6 +575,8 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
}
} catch (InterruptedException ex) {
throw ex;
+ } catch (CorruptIndexException ex) {
Review Comment:
Generally your understanding is correct. I guess this behaviour for now is
better than copying corrupted segment and have problems with that afterwards.
Recovery path should be done as a separate PR since this problem since this
is not specifically Tiered storage problem. Index corruption can be caused for
non TS clusters as well. `
My change is only about avoiding this corruption been uploaded to remote
storage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
