dajac commented on code in PR #14099:
URL: https://github.com/apache/kafka/pull/14099#discussion_r1276677238
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##########
@@ -440,12 +442,13 @@ public void testUpdateSubscriptionMetadata() {
// It should return foo now.
assertEquals(
mkMap(
- mkEntry("foo", new TopicMetadata(fooTopicId, "foo", 1))
+ mkEntry("foo", new TopicMetadata(fooTopicId, "foo", 1,
Collections.emptyMap()))
Review Comment:
Should we update `testUpdateSubscriptionMetadata` to include racks for some
topics? Otherwise, it seems that we don't really test the newly added logic
into `computeSubscriptionMetadata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
