rreddy-22 commented on code in PR #14099:
URL: https://github.com/apache/kafka/pull/14099#discussion_r1276710063
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java:
##########
@@ -764,4 +813,39 @@ public void testNewOffsetCommitTombstoneRecord() {
Record record =
RecordHelpers.newOffsetCommitTombstoneRecord("group-id", "foo", 1);
assertEquals(expectedRecord, record);
}
+
+ // For the purpose of testing let:
+ // a) Number of replicas for each partition = 2
+ // b) Number of racks available in the cluster = 4
Review Comment:
Its applicable to both the mkMapOfPartitionRacks and mkListOfPartitionRacks
methods to show why there's two rackIds in each set and why the mod is 4. I got
confused when I saw the old tests and didn't understand why a certain
calculation was made and what the assumptions behind it were. I initially added
it to the javadoc for the first method but realised it probably doesn't belong
there. I'm not sure if I should place it inside the method for both or where
the correct placement would be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
