kamalcph commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1278982175
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -424,6 +387,18 @@ public int initFileSize() {
return 0;
}
+ public boolean remoteStorageEnable() {
+ return remoteLogConfig.remoteStorageEnable;
+ }
+
+ public long localRetentionMs() {
+ return remoteLogConfig.localRetentionMs ==
LogConfig.DEFAULT_LOCAL_RETENTION_MS ? retentionMs :
remoteLogConfig.localRetentionMs;
+ }
+
+ public long localRetentionBytes() {
+ return remoteLogConfig.localRetentionBytes ==
LogConfig.DEFAULT_LOCAL_RETENTION_BYTES ? retentionSize :
remoteLogConfig.localRetentionBytes;
Review Comment:
yes, correct. The caller should get the real local log retention values when
set to -2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
