divijvaidya commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1280353910
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -122,6 +122,18 @@ public final class RemoteLogManagerConfig {
"is full, fetch requests are served with an error.";
public static final int DEFAULT_REMOTE_LOG_READER_MAX_PENDING_TASKS = 100;
+ public static final String LOG_LOCAL_RETENTION_MS_PROP =
"log.local.retention.ms";
+ public static final String LOG_LOCAL_RETENTION_MS_DOC = "The number of
milliseconds to keep the local log segment before it gets deleted. " +
Review Comment:
perhaps "before it gets eligible for deletion"
(same for retention bytes)
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -122,6 +122,18 @@ public final class RemoteLogManagerConfig {
"is full, fetch requests are served with an error.";
public static final int DEFAULT_REMOTE_LOG_READER_MAX_PENDING_TASKS = 100;
+ public static final String LOG_LOCAL_RETENTION_MS_PROP =
"log.local.retention.ms";
+ public static final String LOG_LOCAL_RETENTION_MS_DOC = "The number of
milliseconds to keep the local log segment before it gets deleted. " +
Review Comment:
should we perhaps add here that this configuration is only used when remote
storage is enabled at a system level?
(same for retention bytes)
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {
public static class RemoteLogConfig {
Review Comment:
could we please add an assertion and a test that remote storage cannot be
enabled for a topic if the remote storage is not enabled at system level?
Please let me know if I am missing something and we already have this
validation check somewhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
