bachmanity1 opened a new pull request, #14142: URL: https://github.com/apache/kafka/pull/14142
1. I think `shouldThrowNullPointerIfKeySerdeIsNull` & `shouldThrowNullPointerIfValueSerdeIsNull` are misleading since the thrown exception is not actually related to the serde key or value. 2. I've replaced `EasyMock` with `Mockito` for the sake of consistency with the rest of the project. P.S. I've noticed that the `streams` & `connect` modules use `EasyMock` & `PowerMock` whereas the rest of the project uses `Mockito` so maybe it would be a good idea to use `Mockito` everywhere for the sake of consistency? If this suggestion is accepted I can create a ticket and work on this. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
