yashmayya commented on code in PR #14142:
URL: https://github.com/apache/kafka/pull/14142#discussion_r1287021377
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/SessionStoreBuilderTest.java:
##########
@@ -118,48 +114,28 @@ public void
shouldHaveCachingAndChangeLoggingWhenBothEnabled() {
}
@Test
- public void shouldThrowNullPointerIfInnerIsNull() {
+ public void shouldThrowNullPointerIfSupplierIsNull() {
final Exception e = assertThrows(NullPointerException.class, () -> new
SessionStoreBuilder<>(null, Serdes.String(), Serdes.String(), new MockTime()));
assertThat(e.getMessage(), equalTo("storeSupplier cannot be null"));
}
@Test
- public void shouldThrowNullPointerIfKeySerdeIsNull() {
- final Exception e = assertThrows(NullPointerException.class, () -> new
SessionStoreBuilder<>(supplier, null, Serdes.String(), new MockTime()));
- assertThat(e.getMessage(), equalTo("name cannot be null"));
- }
-
- @Test
- public void shouldThrowNullPointerIfValueSerdeIsNull() {
- final Exception e = assertThrows(NullPointerException.class, () -> new
SessionStoreBuilder<>(supplier, Serdes.String(), null, new MockTime()));
Review Comment:
Ah, this looks like the same issue as
https://github.com/apache/kafka/pull/14152#discussion_r1284245654
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/SessionStoreBuilderTest.java:
##########
@@ -118,48 +114,28 @@ public void
shouldHaveCachingAndChangeLoggingWhenBothEnabled() {
}
@Test
- public void shouldThrowNullPointerIfInnerIsNull() {
+ public void shouldThrowNullPointerIfSupplierIsNull() {
Review Comment:
```suggestion
public void shouldThrowNullPointerIfStoreSupplierIsNull() {
```
nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
