gharris1727 commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1666104751
@fvaleri That does appear to work, because [server-common is not being excluded from tools-dependant-libs](https://github.com/apache/kafka/blob/b3db905b27ff4133f4018ac922c9ce2beb2d6087/build.gradle#L1895-L1897) like the clients is. I don't think this was intentional, I think it was accidentally left out when server-common was added as a dependency in #12469 . There is a compatibility boundary between server-common and clients in this case, but that was already there before your change. If we choose not to change this compatibility boundary from between server-common + clients to between tools + server-common, then I think the fix you propose is possible. I agree with your reasoning that server-common is a reasonable dependency for the connect-runtime, even if it's only present use is the ThroughputThrottler. I don't really mind whether it's in clients or server-common, as long as it's visible in the dependent modules. If someone later moves the compatibility boundary, and reduces the range of the version mixing (by changing the if condition to `if node.version < LATEST_1_1`) then moving this class around will have no effect anyway, so this fix doesn't make it any harder to add more fixes later. Can you revert the changes in producer_performance.py? they don't seem to have an effect anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
