divijvaidya commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1300024562
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -370,6 +384,10 @@ public long remoteLogIndexFileCacheTotalSizeBytes() {
return remoteLogIndexFileCacheTotalSizeBytes;
}
+ public long getRemoteLogIndexFileCacheTotalSize() {
Review Comment:
In Kafka code base we don't use prefix such as "get" for getters. You can
rename this to `remoteLogIndexFileCacheTotalSize()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
