satishd commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1303795865
##########
docs/configuration.html:
##########
@@ -303,6 +303,11 @@ <h4><a
id="org.apache.kafka.disallowed.login.modules"></a><a id="systempropertie
</tbody></table>
</li>
</ul>
+
+ <h3 class="anchor-heading"><a id="remotestorageconfigs"
class="anchor-link"></a><a href="#remotestorageconfigs">3.10 Remote Storage
Configs</a></h3>
Review Comment:
This feature is known as "Tiered Storage". Let us not change that as it will
cause confusion to users.
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -49,26 +49,26 @@ public final class TopicBasedRemoteLogMetadataManagerConfig
{
public static final String
REMOTE_LOG_METADATA_INITIALIZATION_RETRY_INTERVAL_MS_PROP =
"remote.log.metadata.initialization.retry.interval.ms";
public static final int DEFAULT_REMOTE_LOG_METADATA_TOPIC_PARTITIONS = 50;
- public static final long
DEFAULT_REMOTE_LOG_METADATA_TOPIC_RETENTION_MILLIS = -1L;
+ public static final long DEFAULT_REMOTE_LOG_METADATA_TOPIC_RETENTION_MS =
-1L;
public static final short
DEFAULT_REMOTE_LOG_METADATA_TOPIC_REPLICATION_FACTOR = 3;
public static final long DEFAULT_REMOTE_LOG_METADATA_CONSUME_WAIT_MS = 2 *
60 * 1000L;
public static final long
DEFAULT_REMOTE_LOG_METADATA_INITIALIZATION_RETRY_MAX_TIMEOUT_MS = 2 * 60 *
1000L;
public static final long
DEFAULT_REMOTE_LOG_METADATA_INITIALIZATION_RETRY_INTERVAL_MS = 5 * 1000L;
- public static final String
REMOTE_LOG_METADATA_TOPIC_REPLICATION_FACTOR_DOC = "Replication factor of
remote log metadata Topic.";
- public static final String REMOTE_LOG_METADATA_TOPIC_PARTITIONS_DOC = "The
number of partitions for remote log metadata Topic.";
- public static final String REMOTE_LOG_METADATA_TOPIC_RETENTION_MS_DOC =
"Remote log metadata topic log retention in milli seconds." +
+ public static final String
REMOTE_LOG_METADATA_TOPIC_REPLICATION_FACTOR_DOC = "Replication factor of
remote log metadata topic.";
+ public static final String REMOTE_LOG_METADATA_TOPIC_PARTITIONS_DOC = "The
number of partitions for remote log metadata topic.";
+ public static final String REMOTE_LOG_METADATA_TOPIC_RETENTION_MS_DOC =
"Retention of remote log metadata topic in milliseconds. " +
"Default: -1, that means unlimited. Users can configure this value
based on their use cases. " +
"To avoid any data loss, this value should be more than the
maximum retention period of any topic enabled with " +
- "tiered storage in the cluster.";
- public static final String REMOTE_LOG_METADATA_CONSUME_WAIT_MS_DOC = "The
amount of time in milli seconds to wait for the local consumer to " +
+ "remote storage in the cluster.";
Review Comment:
Ditto for tiered.
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -56,28 +56,28 @@ public final class RemoteLogManagerConfig {
public static final String REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP =
"remote.log.storage.system.enable";
- public static final String REMOTE_LOG_STORAGE_SYSTEM_ENABLE_DOC = "Whether
to enable tier storage functionality in a broker or not. Valid values " +
- "are `true` or `false` and the default value is false. When it is
true broker starts all the services required for tiered storage functionality.";
+ public static final String REMOTE_LOG_STORAGE_SYSTEM_ENABLE_DOC = "Whether
to enable remote storage functionality in a broker or not. Valid values " +
Review Comment:
Let us keep this as "tiered storage"
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -56,28 +56,28 @@ public final class RemoteLogManagerConfig {
public static final String REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP =
"remote.log.storage.system.enable";
- public static final String REMOTE_LOG_STORAGE_SYSTEM_ENABLE_DOC = "Whether
to enable tier storage functionality in a broker or not. Valid values " +
- "are `true` or `false` and the default value is false. When it is
true broker starts all the services required for tiered storage functionality.";
+ public static final String REMOTE_LOG_STORAGE_SYSTEM_ENABLE_DOC = "Whether
to enable remote storage functionality in a broker or not. Valid values " +
+ "are `true` or `false` and the default value is false. When it is
true broker starts all the services required for the remote storage
functionality.";
Review Comment:
Let us keep this as "tiered storage"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
