divijvaidya commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1303972505
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -56,28 +56,28 @@ public final class RemoteLogManagerConfig {
public static final String REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP =
"remote.log.storage.system.enable";
- public static final String REMOTE_LOG_STORAGE_SYSTEM_ENABLE_DOC = "Whether
to enable tier storage functionality in a broker or not. Valid values " +
- "are `true` or `false` and the default value is false. When it is
true broker starts all the services required for tiered storage functionality.";
+ public static final String REMOTE_LOG_STORAGE_SYSTEM_ENABLE_DOC = "Whether
to enable remote storage functionality in a broker or not. Valid values " +
Review Comment:
Hi @satishd
It is on my
[suggestion](https://github.com/apache/kafka/pull/14266#issuecomment-1687769802)
that @tinaselenge made this change. I suggested that because all our publicly
facing configurations are named as "remote storage" and same for code related
files such as RemoteLogManager. Is there a reason we want to use Tiered storage
nomenclature?
I don't have a strong opinion on either but want to ensure that we stick to
one nomenclature in the code base and public docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
