[GitHub] [kafka] satishd commented on a diff in pull request #14301: KAFKA-15351: Ensure log-start-offset not updated to local-log-start-offset when remote storage enabled

[via GitHub]

satishd commented on code in PR #14301:
URL: https://github.com/apache/kafka/pull/14301#discussion_r1307431851


##########
storage/src/test/java/org/apache/kafka/tiered/storage/integration/OffloadAndConsumeFromLeaderTest.java:
##########
@@ -127,7 +127,7 @@ protected void 
writeTestSpecifications(TieredStorageTestBuilder builder) {
                  *       - For topic B, only one segment is present in the 
tiered storage, as asserted by the
                  *         previous sub-test-case.
                  */
-                // .bounce(broker)
+                .bounce(broker)

Review Comment:
   Can you remove prefix (A) in the docs of this class. 



##########
storage/src/test/java/org/apache/kafka/tiered/storage/integration/OffloadAndConsumeFromLeaderTest.java:
##########
@@ -127,7 +127,7 @@ protected void 
writeTestSpecifications(TieredStorageTestBuilder builder) {
                  *       - For topic B, only one segment is present in the 
tiered storage, as asserted by the
                  *         previous sub-test-case.
                  */
-                // .bounce(broker)
+                .bounce(broker)

Review Comment:
   Can you remove prefix (A) in the docs of this class. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org