[GitHub] [kafka] showuon commented on a diff in pull request #14301: KAFKA-15351: Ensure log-start-offset not updated to local-log-start-offset when remote storage enabled

[via GitHub]

showuon commented on code in PR #14301:
URL: https://github.com/apache/kafka/pull/14301#discussion_r1308282470


##########
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java:
##########
@@ -238,7 +242,11 @@ public void stop(int brokerId) {
     }
 
     public void start(int brokerId) {
+        boolean allBrokersDead = harness.aliveBrokers().isEmpty();
         harness.startBroker(brokerId);
+        if (allBrokersDead) {
+            reinitClients();
+        }

Review Comment:
   Will this cause we init clients twice when 1st start up? 
   If we already reinit clients in `bounce` method, why should we reinit 
clients here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org