kamalcph commented on code in PR #14301: URL: https://github.com/apache/kafka/pull/14301#discussion_r1308534921
########## core/src/main/scala/kafka/log/UnifiedLog.scala: ########## @@ -1882,6 +1877,17 @@ object UnifiedLog extends Logging { val UnknownOffset = LocalLog.UnknownOffset + def isRemoteLogEnabled(remoteStorageSystemEnable: Boolean, Review Comment: We want to know whether the remote log is enabled or not for the topic before the creation of `UnifiedLog` object. So, moved the logic to the companion object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org