kamalcph commented on code in PR #14330: URL: https://github.com/apache/kafka/pull/14330#discussion_r1314697994
########## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ########## @@ -1066,50 +1066,53 @@ public static boolean isRemoteSegmentWithinLeaderEpochs(RemoteLogSegmentMetadata // Check for out of bound epochs between segment epochs and current leader epochs. Integer segmentFirstEpoch = segmentLeaderEpochs.firstKey(); Integer segmentLastEpoch = segmentLeaderEpochs.lastKey(); + + // FIXME: We have to remove the below check too for `DELETE_RECORDS` API to work properly. Review Comment: Not clear on the usage of `isRemoteSegmentWithinLeaderEpochs` validation in the segment deletion path. Commented out the code for now, will go through the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org