satishd commented on code in PR #14330:
URL: https://github.com/apache/kafka/pull/14330#discussion_r1316941057
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -856,11 +856,10 @@ public boolean
deleteRetentionTimeBreachedSegments(RemoteLogSegmentMetadata meta
private boolean
deleteLogStartOffsetBreachedSegments(RemoteLogSegmentMetadata metadata, long
startOffset)
throws RemoteStorageException, ExecutionException,
InterruptedException {
boolean isSegmentDeleted = deleteRemoteLogSegment(metadata, x
-> startOffset > x.endOffset());
- if (isSegmentDeleted && retentionSizeData.isPresent()) {
+ if (isSegmentDeleted) {
Review Comment:
Are we not checking with retentionDataSize as they are beyond
log-start-offset based on your earlier comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
