[GitHub] [kafka] dengziming commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

[via GitHub]

dengziming commented on code in PR #14306:
URL: https://github.com/apache/kafka/pull/14306#discussion_r1314913328


##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -320,6 +323,19 @@ public short registerBrokerRecordVersion() {
         }
     }
 
+    public short registerControllerRecordVersion() {
+        if (isAtLeast(MetadataVersion.IBP_3_6_IV2)) {

Review Comment:
   We are not using `IBP_3_7_IV0`, does this mean a old-version controller can 
register a controller with an new-version controller? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org